Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bs-platform from being rebuild every time when running yarn add #2207

Closed
sgronblo opened this issue Oct 29, 2017 · 1 comment
Closed

Comments

@sgronblo
Copy link

Trying to write a small test app using bucklescript-tea. I noticed that every time I ran something like yarn add @types/webpack ie. entirely unrelated to Bucklescript, bs-platform was being rebuilt every time any way.

After asking about this on the ReasonML discourse it turns out that this is a known "bug" with yarn where it apparently calls packages' postinstall script every time: yarnpkg/yarn#932

Somebody on the Discourse was saying that packages would need to work around this currently by creating a file to represent having built already and then checking if that file exists on subsequent runs. Would this make sense to add to bs-platform until this problem is fixed?

@bobzhang
Copy link
Member

I am fine with work around, if we add a build stamp file, how do we run postinstall explicitly? by manually removing the build stamp file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants