Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rescript-lang/rescript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 711b5f1
Choose a base ref
...
head repository: rescript-lang/rescript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f7f1e5e
Choose a head ref
  • 9 commits
  • 98 files changed
  • 1 contributor

Commits on Dec 18, 2024

  1. merge conflict

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    65b1c68 View commit details
    Browse the repository at this point in the history

  2. AST: test storing arity in function type

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    2493959 View commit details
    Browse the repository at this point in the history

  3. WIP: extend types and type propagation with arity 

    This needs some info from function definition that is not readily available. Better to postpone this until arity is explicit in function definitions.
    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    6fec229 View commit details
    Browse the repository at this point in the history

  4. Fix uncurried function type handling in FFI and type system 

    Fix uncurried function type handling in FFI and type system

This commit improves handling of uncurried function types, particularly in FFI and
the type system:

- Add arity information to @obj externals by returning arity from process_obj
- Fix filter_arrow to properly handle arity in type unification
- Remove invalid assert false in ast_uncurried.ml
- Update type_function and type_application to properly handle arity information
- Pass arity through to is_ignore function for consistent type checking

These changes help ensure proper type checking and arity handling for uncurried
functions, especially in FFI bindings using @obj.
    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    53b9824 View commit details
    Browse the repository at this point in the history

  5. Update TestPpx.res.jsout

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    c0260ea View commit details
    Browse the repository at this point in the history

  6. Remove remaining uses of type_to_arity.

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    5d0977a View commit details
    Browse the repository at this point in the history

  7. Move arity decoding to ast conversion.

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    d647c99 View commit details
    Browse the repository at this point in the history

  8. Remove the arity parameter of type function$.

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    45ce228 View commit details
    Browse the repository at this point in the history

  9. Update CHANGELOG.md

    @cristianoc
    cristianoc committed Dec 18, 2024
    Configuration menu
    Copy the full SHA
    f7f1e5e View commit details
    Browse the repository at this point in the history
Loading