Build static linux binaries, including arm64 #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cknitt
commented
May 1, 2024
•
cknitt
commented
- Build static binaries for Linux which fixes glibc compatibility issues. Uses same Docker container as in the rescript-compiler repo.
- Build Linux ARM binaries.
cknitt
force-pushed
the
static-linux-bins
branch
6 times, most recently
from
7396be3 to
d0f6d7e
Compare
cknitt
changed the title
cknitt
force-pushed
the
static-linux-bins
branch
2 times, most recently
from
f8ef3d6 to
37a4909
Compare
cknitt
changed the title
zth
approved these changes
May 2, 2024
|
The existing logic should be fine: rescript-vscode/client/src/utils.ts Line 6 in 3b5824b But I haven't really tested it on Linux ARM64 yet. Could you try it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.