-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion for type t values #924
Conversation
@zth It's ready for review |
@DZakh awesome! Have a look as soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice work! Was it OK to find your way around the repo/code?
There's a spelling mistake to fix, and then a changelog would be good as well, but then it's good to go.
Yes, it was the first time I worked on an IDE extension and it happened to be easier than I expected. I usually start with setting up the environment, running tests, and checking that changing code actually affects something. So I followed the As for the code structure, I don't really know anything besides the code I touched. I just opened the PR #884 and found a place I need, so I have no idea about other parts of the project. |
Ping me the next time you're looking at something in the repo and I can show you a bit more around debugging etc. |
I found it quite easily myself. I like to dig down myself first, this way I have better understanding of the project. |
The only problem, that I have a fear to start contributing sometimes 😅 |
There are tools to dig easier. That's what I mean. |
* Add completion for type t values * Update snapshots * Add test * Add test for labeled arg as well * Fixes after review
An example from our project. We have a
Money.zero
value and now it's also included in the autocomplete: