Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for namespace when filtering pipe completion items #843

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Account for namespace when filtering pipe completion items #843

merged 2 commits into from
Nov 12, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Nov 11, 2023

This handles filtering out namespaced modules when producing the relative completion path in pipe completion.

Before (the issue is the namespace, that should be covered by open Test above):
image

After (namespace is now accounted for, which leads to Test disappearing correctly from the completion path):
Pasted Graphic 3

@zth zth requested a review from cristianoc November 11, 2023 20:18
@zth zth merged commit 6ea3d1c into master Nov 12, 2023
@zth zth deleted the filter-namespace-in-pipe-completion branch November 12, 2023 09:02
@zth zth mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc