Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword list specified in grammer #84

Merged
merged 1 commit into from Mar 13, 2021
Merged

Fix keyword list specified in grammer #84

merged 1 commit into from Mar 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2021

Some of keywords are from OCaml that are not from Rescript docs, Hence i filter out all keyword specified in docs from keyword list specified in grammer

Here is the fixes

List of keyword that were specified in grammer json but not in docs
nonrec, val, then, fun, virtual, do, done, catch, begin, pub, or, library, class, new, finally, inherit, export, object, pri, private, import, raise, functor

List of keyword that were specified in rescript docs but not in grammer json
true, include, open, when, with, false, type

@bobzhang
Copy link
Member

LGTM. CC @chenglou

@chenglou
Copy link
Member

Thanks!

@chenglou chenglou merged commit b8984bd into rescript-lang:master Mar 13, 2021
chenglou added a commit to rescript-lang/rescript-sublime that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants