Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docgen(fix): Remove formatCode function #836

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

aspeddro
Copy link
Contributor

For some reason formatCode don`t print signature for some externals, see Belt.Int

Shared.{type,decl}ToString already does the formatting

Example:

external \"-": (int, int) => int = "%subint"

Before:

{
  "name": "Lib",
  "docstrings": [],
  "items": [
  {
    "id": "Lib.-",
    "kind": "value",
    "name": "-",
    "signature": "let _: %rescript.typehole",
    "docstrings": []
  }]
}

After:

{
  "name": "Lib",
  "docstrings": [],
  "items": [
  {
    "id": "Lib.-",
    "kind": "value",
    "name": "-",
    "signature": "let -: (. int, int) => int",
    "docstrings": []
  }]
}

@zth zth merged commit 65c25b0 into rescript-lang:master Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants