Support rescript.json #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! And you tested that everything worked with both rescript.json and bsconfig.json, including the code analyzer etc? cc @cristianoc |
Same comment. Looks good if everything is tested. |
fhammerschmidt
force-pushed
the
support-rescript-json
branch
from
9eb0ef8 to
86471bf
Compare
|
I tested it and of course found some missing checks. Should work now for both monorepos and normal ones. |
|
Tested against a big monorepo project of ours, worked fine, even with rescript.json and bsconfig.json mixed across packages. |
|
Excellent! Merging and we can fix in follow ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave it a try, not sure if it is the right approach though.