-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete for functions creating React.element when in a JSX context #681
Merged
+474
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Jan 7, 2023
zth
commented
Jan 7, 2023
cristianoc
reviewed
Jan 8, 2023
cristianoc
reviewed
Jan 8, 2023
cristianoc
reviewed
Jan 8, 2023
cristianoc
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restoring context seems wrong.
cristianoc
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead merge after fixing the code for restoring the context.
6ac3aef
to
1f7ac44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I've wanted for a while. This will add
React.string
,React.array
etc to the completion items for relevant types in pipe when in a JSX context. Being in a JSX context is defined as a) being in the body of amake
function annotated with@react.component
, or b) being inside of JSX.Example:
Doing pipe completion on an
int
in JSX context will returnReact.int
in the completion items, in addition to the builtin completions forint
.This accomplishes two things:
React
, and then the fn you're after.React.element
producing functions in JSX.