-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion snippet support #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the support for snippets something configured from the server?
Not sure how that's supposed to work in practice. If it's a server side config or something else.
Basically, the client hooking up the server says whether it supports snippets or not. If it supports snippets, we're allowed to use the snippet syntax in So, in practice, this is progressive enhancement. If the client using the LSP supports snippets we'll send them if wanted, and if not, we won't. |
Do we support clients that don't support snippets? Just wondering whether we should just have this on. |
I'm pretty sure there are variants of vim people are using that at least requires extra configuration to support snippets. I think it's safer to leave it turned off unless the client asks for it. Which reminds me I need to actually hook things up properly here to what the client says, I always send |
@cristianoc fixed in the last commit. |
2c4f080
to
2da1313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as snippet support is hooked up from the .ts side.
This adds support for snippets in completion. Snippets lets us tell the editor where we want the cursor to move as the user tabs its way through the newly inserted text.