Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5 #6

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix #5 #6

merged 1 commit into from
Sep 7, 2020

Conversation

illbexyz
Copy link
Contributor

@illbexyz illbexyz commented Sep 1, 2020 •
edited
Loading

I initially tried uriToFilePath from vscode-languageserver but I found out it's deprecated in favor of uriToFsPath from vscode-uri, which I had to add in package.json.

Tested on Windows 10 and MacOS. I wasn't able to run scripts/e2e.sh though.

@samcf samcf mentioned this pull request Sep 5, 2020
Closed
@chenglou chenglou merged commit f400090 into rescript-lang:master Sep 7, 2020
@chenglou
Copy link
Member

chenglou commented Sep 7, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illbexyz @chenglou