Add rescript.settings.platformPath and correctly determine its default value #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minnozz
changed the title
Minnozz
force-pushed
the
monorepo-bsc-exe
branch
from
5a525d4 to
8f1b39f
Compare
Minnozz
force-pushed
the
monorepo-bsc-exe
branch
from
8f1b39f to
f57d9cb
Compare
Should fix formatting in monorepos. Fixes rescript-lang#572
Minnozz
force-pushed
the
monorepo-bsc-exe
branch
from
f57d9cb to
cc7923e
Compare
Minnozz
changed the title
|
I tested it on my monorepo and it did fix my autoformatting issue! Thanks @Minnozz! |
|
Tried it on two monorepo projects. I had no issues before, but also did not find any regression with this build. |
|
@Minnozz I'm inclined to merge this since it seems to fix setups that recently broke. Would you be available to help fix unforeseen issues that might come from this? Not necessarily thinking there will be any issues, but a lot of the ad hoc monorepo fixes we've merged has broken someone else's monorepo setup. Hence my question. |
|
@zth Yes, I'll do my best to fix any issues |
Thank you! |
zth
pushed a commit
that referenced
this pull request
Sep 28, 2022
…t value (#573) * Tweak description of rescript.settings.binaryPath * Add rescript.settings.platformPath * Add utils.findFilePathFromProjectRoot() * Remove unused utils.findBscBinary() * Rewrite algorithm to find bsc.exe based on platformPath Should fix formatting in monorepos. Fixes #572 Co-authored-by: Paul Tsnobiladzé <paul.tsnobiladze@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the setting
rescript.settings.platformPathand fixes the algorithm to find it if the setting is not specified. This should fix formatting in monorepos, which relies onbsc.exe.Fixes #572