Checking if a file is a res file #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
reviewed
Aug 3, 2022
analysis/src/Hint.ml
Outdated
| @@ -82,7 +82,7 @@ let inlay ~path ~pos ~maxLength ~debug = | |||
| Ast_iterator.default_iterator.value_binding iterator vb | |||
| in | |||
| let iterator = {Ast_iterator.default_iterator with value_binding} in | |||
| (if Files.exists path && Filename.check_suffix path ".res" then | |||
| (if Files.isResFile path then | |||
There was a problem hiding this comment.
I'm not sure that this does it.
The temptation could be else ... for .resi files which would leak to a crash.
Any other ideas?
There was a problem hiding this comment.
Check the latest commit, what do you think about that? Slightly harder at to accidentally do the wrong thing at least I think, but still not fool proof.
cristianoc
approved these changes
Aug 3, 2022
|
Fixed the name! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #539