Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure updated config is synced on use of restart command #438

Merged
merged 2 commits into from
May 30, 2022

Conversation

zth
Copy link
Collaborator

@zth zth commented May 30, 2022

Initial read configuration was never refreshed as the restart command runs, which means you'd always get potentially stale initial config after a restart.

Also clean up a few init things that I suspect has never been cleaned up after the initial adaption of the LS client example.

@zth zth requested a review from cristianoc May 30, 2022 11:44
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

The only thing that comes to mind, is how to make it completely explicit that the code that follows createLanguageClient is the global state. (which is preserved on restart).

@cristianoc
Copy link
Collaborator

Looks great.

The only thing that comes to mind, is how to make it completely explicit that the code that follows createLanguageClient is the global state. (which is preserved on restart).

In fact, there's one other small bit of global state:

let client: LanguageClient;

which is followed by a bunch of commented out code. Then the createLanguageClient function. Then the rest of the global state.

@zth zth merged commit f6208a8 into master May 30, 2022
@zth zth deleted the fix-settings-sync-on-restart branch May 30, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants