Skip to content

Dead code analysis editor mode via reanalyze #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 17, 2022
Merged

Dead code analysis editor mode via reanalyze #334

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ddf27f5
implement basic commands for running dead code analysis via reanalyze…
zth Dec 28, 2021
5e2f0bc
change approach, and set up the dead code analysis as an explicit mod…
zth Dec 30, 2021
a9a0fa9
clarify
zth Dec 30, 2021
1c204fd
cleanip
zth Dec 30, 2021
0dabb4d
keep state of what directory the dead code analysis was activated from
zth Dec 30, 2021
7970869
implement basic commands for running dead code analysis via reanalyze…
zth Dec 28, 2021
ca52019
change approach, and set up the dead code analysis as an explicit mod…
zth Dec 30, 2021
5b96014
clarify
zth Dec 30, 2021
7171ce7
cleanip
zth Dec 30, 2021
af7bc5f
keep state of what directory the dead code analysis was activated from
zth Dec 30, 2021
6fca063
Merge branch 'feat/dead-code-analysis-via-reanalyze' of github.com:zt…
zth Jan 2, 2022
aacb83d
support picking up full dead module diagnostics. mark dead code diagn…
zth Jan 2, 2022
6de5e3d
fix line parsing issue. improve dead module full file highlight heuri…
zth Jan 3, 2022
d7c8d8a
minor touch ups
zth Jan 3, 2022
8b596af
smoothen diagnostics update experience
zth Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify
  • Loading branch information
@zth
zth committed Dec 30, 2021
commit a9a0fa9394ba8240e7d19cfb7b73761ee2c73a52
9 changes: 5 additions & 4 deletions client/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,16 @@ export function activate(context: ExtensionContext) {
clientOptions
);

// Create a custom diagnostics collection, for cases where we want to report diagnostics
// programatically from inside of the extension.
// Create a custom diagnostics collection, for cases where we want to report
// diagnostics programatically from inside of the extension. The reason this
// is separate from the diagnostics provided by the LS server itself, is that
// this should be possible to clear independently of the other diagnostics
// coming from the ReScript compiler itself.
let diagnosticsCollection = languages.createDiagnosticCollection("rescript");

// This map will hold code actions produced by the dead code analysis.
let diagnosticsResultCodeActions: DiagnosticsResultCodeActionsMap = new Map();

let inDeadCodeAnalysisMode = { current: false };

let deadCodeAnalysisRunningStatusBarItem = window.createStatusBarItem(
StatusBarAlignment.Right
);
Expand Down