Additional completion tests #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These have moved to the compiler. |
|
No we need to keep it around for the foreseeable future, the extension will still ship this code and we need to be able to make fixes to it too since it affects all currently released versions of ReScript. This particular PR is about the dot-completion feature, which I'll port to the compiler repo once we've merged it. So it's fine. |
zth
pushed a commit
that referenced
this pull request
Jan 2, 2025
* Add Rxjs completion test * Add Rxjs binding example * Extend Rxjs test with fully qualified access * Add@editor.completeFrom and incomplete test output * Add passing test for property completion * Test still works when types are not named t. * Add test for @editor.completeFrom
zth
added a commit
that referenced
this pull request
Jan 2, 2025
* wip complete pipeable functions from dot completion on record when record is type t of module * correctly insert completion item text removing the dot when selecting a pipe function * add experimental mainTypeForModule annotation * complete modules in payload of mainTypeForModule * rename attribute * hover for new decorator * allow extra module completions also for pipe * make sure completions work across files * filter pipe completions to only applicable functions * pipe complete only for functions that take the expected type as the first argument * start refactoring dot completion everywhere * refactor dot completion * add a few more synthetic * disable verbose log * cleanup * pipe dot completion for builtins * Add example case (#1058) * Additional completion tests (#1062) * Add Rxjs completion test * Add Rxjs binding example * Extend Rxjs test with fully qualified access * Add@editor.completeFrom and incomplete test output * Add passing test for property completion * Test still works when types are not named t. * Add test for @editor.completeFrom * make dot completion everywhere actually work * do not care about ExtractedType now that we have incremental type checking * refactor to share pipe completion code logic * cleanup * cleanup * fix debug command * up rescript in test project * change strategy for removing dot on completion * contonous dot completion * handle dot completions on piped idents * handle scope * inline pipe completion logic again * refactor * more compl spec * refactor * changelog --------- Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zth, I've added a few more test cases based on my last project I'm working on:
RxjsCompletion.resit should complete from the parent moduleCompletionPipeProperty.resalready works, could be interested to add for regression sake.CompletionMultipleEditorCompleteFrom.resdidn't work a single attribute either. Seems interesting to have regression-wise.