🚑 - Monorepo hotfix #1035
Merged
🚑 - Monorepo hotfix #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrolich
force-pushed
the
hotfix-monorepo
branch
from
ef6b44f to
ad51628
Compare
jfrolich
commented
Sep 3, 2024
| "vscode-languageserver": "^8.0.1", | ||
| "vscode-languageserver-protocol": "^3.17.1" | ||
| } | ||
| "name": "@rescript/language-server", |
There was a problem hiding this comment.
for some reason this was tab formatted (and in the server it's spaces - I think spaces is more standard)
jfrolich
commented
Sep 3, 2024
| @@ -70,7 +69,7 @@ export let findProjectRootOfFile = ( | |||
| } else { | |||
| const isDir = path.extname(source) === ""; | |||
| return findProjectRootOfFileInDir( | |||
| isDir ? path.join(source, "dummy.res") : source | |||
| isDir && !allowDir ? path.join(source, "dummy.res") : source | |||
There was a problem hiding this comment.
This caused the fix to not work :|
jfrolich
force-pushed
the
hotfix-monorepo
branch
from
ad51628 to
5ae68f7
Compare
update correct version
jfrolich
force-pushed
the
hotfix-monorepo
branch
from
5ae68f7 to
ced6afd
Compare
|
You need to run |
🙈 done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.