Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to definition returns wrong location #652

Closed
aspeddro opened this issue Dec 14, 2022 · 2 comments
Closed

Go to definition returns wrong location #652

aspeddro opened this issue Dec 14, 2022 · 2 comments

Comments

@aspeddro
Copy link
Contributor

aspeddro commented Dec 14, 2022 •
edited
Loading

Go to definition in <Sidebar return wrong location.

dune exec rescript-editor-analysis definition ~/Desktop/projects/rescript-lang.org/src/layouts/ApiLayout.res 123 9

{"uri": "file:///home/pedro/Desktop/projects/rescript-lang.org/src/layouts/SidebarLayout.res", "range": {"start": {"line": 212, "character": 4}, "end": {"line": 212, "character": 8}}}

The correct location is ApiLayout.res
@cristianoc
Copy link
Collaborator

I think this refers to <Sidebar a few lines above.

cristianoc added a commit that referenced this issue Dec 15, 2022
@cristianoc
Add an example of wrong reference with inner modules, .resi, and shad…
e220d26 
…owing.

In the example, the reference to `DefinitionWithInterface.Inner.y` leads to `DefinitionWithInterface.y` instead.
This seems to happen only when there is an interface file, and the outer module has the same value named `y` as the inner module.

See #652
@cristianoc cristianoc mentioned this issue Dec 15, 2022
Merged
cristianoc added a commit that referenced this issue Dec 15, 2022
@cristianoc
Add an example of wrong reference with inner modules, .resi, and shad…
0f55813 
…owing.

In the example, the reference to `DefinitionWithInterface.Inner.y` leads to `DefinitionWithInterface.y` instead.
This seems to happen only when there is an interface file, and the outer module has the same value named `y` as the inner module.

See #652
@cristianoc
Copy link
Collaborator

Fixed in #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristianoc @aspeddro