Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Understand paths in -open in bsc-flags #607

Closed
cristianoc opened this issue Oct 21, 2022 · 3 comments · Fixed by #608
Closed

Understand paths in -open in bsc-flags #607

cristianoc opened this issue Oct 21, 2022 · 3 comments · Fixed by #608

Comments

@cristianoc
Copy link
Collaborator

E.g. "-open ReScriptJs.Js" is not recognised
while "-open ReScriptJs", "-open Js" is
@cristianoc
Copy link
Collaborator Author

CC @zth

@cristianoc cristianoc changed the title Understand paths in -open in bcc-flags Understand paths in -open in bsc-flags Oct 21, 2022
cristianoc added a commit that referenced this issue Oct 21, 2022
@cristianoc
Fis issue where module paths in -open bsc-flags such as "-open Re…
ea21163 
…ScriptJs.Js" were not recognized

Fixes #607
@cristianoc cristianoc mentioned this issue Oct 21, 2022
Merged
cristianoc added a commit that referenced this issue Oct 21, 2022
@cristianoc
Fis issue where module paths in -open bsc-flags such as "-open Re…
04e3d8f 
…ScriptJs.Js" were not recognized

Fixes #607
@cristianoc cristianoc reopened this Oct 21, 2022
@cristianoc
Copy link
Collaborator Author

The semantics of "-open ReScriptJs", "-open Js" is not the same as "-open ReScriptJs.Js". To be accurate, this should be taken into account.

So this issue is not completely fixed yet.

@zth
Copy link
Collaborator

zth commented Oct 31, 2022

This is now fixed.

@zth zth closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zth @cristianoc