Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected hover result on nested record members #52

Closed
zth opened this issue Dec 26, 2020 · 0 comments · Fixed by rescript-lang/rescript-editor-support#48
Closed

Unexpected hover result on nested record members #52

zth opened this issue Dec 26, 2020 · 0 comments · Fixed by rescript-lang/rescript-editor-support#48

Comments

@zth
Copy link
Collaborator

zth commented Dec 26, 2020

This is using 1.0.2 on macOS.

In summary - hovering nested record members seems to show the wrong information (some form of off-by-one error). Here's a reproduction case with comments on what's happening: https://github.com/zth/rescript-editor-tooling-playground/blob/master/src/HoverIssues.res

I posted about this on the RLS repo as well way back, so it's probably originally an issue in RLS: jaredly/reason-language-server#419
@amiralies amiralies mentioned this issue Jan 1, 2021
Closed
cristianoc added a commit to rescript-lang/rescript-editor-support that referenced this issue Jan 4, 2021
@cristianoc
Fix hovering on record fields.
cc33883 
Fixes rescript-lang/rescript-vscode#52

Continuation of #47

Show the correct type information, including type definition for record fields.
Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type).
Clean up code in References.
@cristianoc cristianoc mentioned this issue Jan 4, 2021
Merged
cristianoc added a commit to rescript-lang/rescript-editor-support that referenced this issue Jan 4, 2021
@cristianoc
Fix hovering on record fields.
d2143a5 
Fixes rescript-lang/rescript-vscode#52

Continuation of #47

Show the correct type information, including type definition for record fields.
Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type).
Clean up code in References.
cristianoc added a commit that referenced this issue Jan 6, 2021
@cristianoc
Sync rescript-editor support to commit 214d220.
d857b04 
- Fix type shown when hovering on record fields (see #52), and doc comments for records.
- Fix issue where type variables are printed with global renaming when hovering or autocompleting a module (see rescript-lang/rescript-editor-support#38).
- Fix issue where a log file was always created (see #47).
- Add support for hover on the id of toplevel module definitions (```module Id = ...```).
@cristianoc cristianoc mentioned this issue Jan 6, 2021
Merged
chenglou pushed a commit that referenced this issue Apr 23, 2021
@cristianoc
See what's up with Windows CI. (#52)
bf52b45 
* Fix Windows CI.
chenglou pushed a commit to chenglou/rescript-editor-support that referenced this issue Apr 24, 2021
@cristianoc @chenglou
Fix hovering on record fields.
bf28929 
Fixes rescript-lang/rescript-vscode#52

Continuation of rescript-lang#47

Show the correct type information, including type definition for record fields.
Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type).
Clean up code in References.
chenglou pushed a commit that referenced this issue Apr 24, 2021
@cristianoc @chenglou
See what's up with Windows CI. (#52)
6a44056 
* Fix Windows CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hovering on record fields. rescript-lang/rescript-editor-support
1 participant
@zth