Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.2.0 breaks syntax highlighting after backtick #345

Closed
cknitt opened this issue Jan 20, 2022 · 5 comments
Closed

Version 1.2.0 breaks syntax highlighting after backtick #345

cknitt opened this issue Jan 20, 2022 · 5 comments

Comments

@cknitt
Copy link
Member

cknitt commented Jan 20, 2022

1.1.3:
Bildschirmfoto 2022-01-20 um 13 27 43

1.2.0:
Bildschirmfoto 2022-01-20 um 13 27 15

@cristianoc
Copy link
Collaborator

Coming from here:
#325

Looks like and analogue of this question has been asked before with no satisfactory suggestions:
https://stackoverflow.com/questions/59303371/is-there-any-way-to-skip-the-escaped-quote-inside-the-double-quoted-textmate-rul

Unless someone has an alternative suggestion, the way forward is to revert #325
and live with the fact that escaped backticks break highlighting.

cristianoc added a commit that referenced this issue Jan 20, 2022
Fix issue with highlighting of templates introduced in #325

and reported in

#345
@cristianoc
Copy link
Collaborator

Turns out one of the stack overflow suggestions, to use negative-look-behind, seems to work (though the response states it does not):
#346

Tried on these patterns:

let a = "abc"

Js.log(` \` ccc ${a} ddd  `)

Js.log(`a = ${a}`)

Js.log(``)

let b = 34

@cknitt would you be able to test that, and check that no other issues arise?

@cknitt
Copy link
Member Author

cknitt commented Jan 20, 2022

Yes, I will test against one of our codebases.

@cknitt
Copy link
Member Author

cknitt commented Jan 20, 2022

@cristianoc Looks good now! 🎉 Thanks a lot! 😄

@cristianoc
Copy link
Collaborator

Great! Thanks for checking.

cristianoc added a commit that referenced this issue Jan 20, 2022
Fix issue with highlighting of templates introduced in #325

and reported in

#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants