Skip to content

Version 0.11.0-rc.1 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Version 0.11.0-rc.1 #69

merged 3 commits into from
Oct 19, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 19, 2022

No description provided.

@cknitt cknitt requested review from mununki and cristianoc October 19, 2022 07:34
@cknitt cknitt changed the title 0.11.0 rc.1 Version 0.11.0-rc.1 Oct 19, 2022
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @rescript/react is not a valid GitHub project name?

@cknitt
Copy link
Member Author

cknitt commented Oct 19, 2022

I guess not, but it's the name of the npm package. I can change it back if you prefer that.

@cknitt
Copy link
Member Author

cknitt commented Oct 19, 2022

Or we write something like "ReScript bindings for React".

I just didn't want people (who do not read the installation instructions below) to think "rescript-react" is the name of the npm package.

@cristianoc
Copy link
Contributor

I agree with the changes. I was just wondering if one can rename the GitHub project too.

@cknitt cknitt merged commit 1959c4c into master Oct 19, 2022
@cknitt cknitt deleted the 0.11.0-rc.1 branch October 19, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants