Feat: add loading dom prop #45
Conversation
src/ReactDOM.res
Outdated
| @optional | ||
| list: string, | ||
| @optional | ||
| loading: string, /* "lazy", "eager" */, |
There was a problem hiding this comment.
We can specify the values exactly at the type level:
loading: [#lazy | #eager],
There was a problem hiding this comment.
Okay I made the change. I had to wrap lazy in quotes because it is a reserved keyword. Also, I used string because I noticed other props that are have a small/finite number of options just use string. (Like method and inputMode)
|
This PR fixes #43 once the feedback from yawaramin is fixed :) |
yawaramin
left a comment
yawaramin
left a comment
There was a problem hiding this comment.
Thanks. The other props use string type because they predate ReScript's feature of polymorphic variants compiling to strings. I think it would make sense to update the prop types where appropriate.
|
Is that something we want to do on this PR? |
|
Not necessarily. I +1'd this PR as I don't think it needs to do anything else. My comment was more about future improvements. |
|
@Kingdutch @yawaramin sorry for the delay. I can't seem to merge this PR though. |
|
Hi, I'm quite late for the party. |
5 participants
I would like to add the loading property for Domprops. This allows someone to add the
loadingproperty on an image for using html-based browser-native lazy loading.