Deprecate stringToComponent

[rickyvetter]

The ppx inserts JS objects of various shapes. Needs to be flexible on props type.

[cknitt]

@rickyvetter @mattdamon108 Is this still relevant?

[mununki]

I don't know the context of this PR enough. But, I think stringToComponent can be deprecated for backward compatibility. Actually, ppx v3 and v4 seem not to be using it.

[cknitt]

@mattdamon108 If it is really not used by either PPX I think we may as well remove it (and only leave it in ReactDOM_V3.res for backward compatibility).

[mununki]

I agree. But the rescript-react is not only for ppx, maybe just maybe someone wants to use it with v4? too much imagination?

[mununki]

I admit too much imagination 😄 Yes, I think we can remove it.

[mununki]

I found https://github.com/rescript-lang/syntax/blob/master/tests/printer/expr/bsObj.res but we can fix the test.

[cknitt]

I think the stringToComponent in the test does not really matter anyway, the test source is just parsed and reprinted AFAIK.

[mununki]

I think the stringToComponent in the test does not really matter anyway, the test source is just parsed and reprinted AFAIK.

Good. How about deprecate it first to merge this PR? I guess that comment seems stale though.

[mununki]

Want me to add commit to update comment to this PR directly?

[cknitt]

Want me to add commit to update comment to this PR directly?

Yes, please, thanks!

[mununki]

Rebased and updated d75d148 @cknitt

[cknitt]

Thanks!