Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open graph images #992

Merged
merged 4 commits into from
Mar 20, 2025
Merged

fix open graph images #992

merged 4 commits into from
Mar 20, 2025

Conversation

jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented Mar 19, 2025

fixes: #986

  • added fallback image
  • added full url to image, which seems to be required for X

We should consider adding more unique images for og, so it's not just the same one all the time. I added one for the playground to test out how it'll look.

Before

image

After

image
image

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 7:57pm

Copy link

cloudflare-workers-and-pages bot commented Mar 19, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc85602
Status: ✅  Deploy successful!
Preview URL: https://f1883914.rescript-lang.pages.dev
Branch Preview URL: https://vlk-og-images.rescript-lang.pages.dev

View logs

@jderochervlk jderochervlk marked this pull request as ready for review March 19, 2025 20:01
@jderochervlk jderochervlk changed the title add fallback og:image fix open graph images Mar 19, 2025
@fhammerschmidt
Copy link
Member

Very nice, thank you!

@fhammerschmidt fhammerschmidt merged commit 75ef824 into master Mar 20, 2025
4 checks passed
@jderochervlk jderochervlk deleted the vlk-og-images branch March 20, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Graph (og) images don't look correct
2 participants