Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic JSX transform #806

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Generic JSX transform #806

merged 4 commits into from
Jan 29, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 29, 2024

The generic JSX transform will land in 11.1. Here's some docs, please give feedback.

I removed the "Tips & Tricks" section because I felt it didn't add much now that we have a built in generic JSX transform. Let me know if you think otherwise.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 0:44am

@fhammerschmidt
Copy link
Member

Love it!
Delivering a feature and subsequently the docs for it should be the default! 👍

@fhammerschmidt
Copy link
Member

We may want to update this one too: https://rescript-lang.org/syntax-lookup#react-component-decorator and/or add a jsx-component-decorator

@zth
Copy link
Collaborator Author

zth commented Jan 29, 2024

Yes, and the config section. Forgot about that one.

@zth
Copy link
Collaborator Author

zth commented Jan 29, 2024

@fhammerschmidt decorator added. Build schema adapted here: rescript-lang/rescript#6588

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Jan 29, 2024

LGTM!
(well except for the failing URL test)

@zth zth merged commit 8db921f into master Jan 29, 2024
@zth zth deleted the generic-jsx-transform branch January 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants