Skip to content

Migrate from JSX v3’s doc redirection error #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JiaeK opened this issue Jan 9, 2023 · 2 comments · Fixed by #643
Closed

Migrate from JSX v3’s doc redirection error #641

JiaeK opened this issue Jan 9, 2023 · 2 comments · Fixed by #643

Comments

@JiaeK
Copy link
Contributor

JiaeK commented Jan 9, 2023

Currently, switching between documentation versions using sidebar (v.0.10.0 to v.0.11.0) of Migrate from JSX v3’s doc gives 404 errors like the below:
redirection prob

That is, Migrate from JSX v3’s doc and the former version of it, AKA Migrate from ReasonReact’s doc, have redirection problems.
@cristianoc
Copy link
Contributor

cristianoc commented Jan 10, 2023 •
edited
Loading

@mununki I guess this is because the paths are different: migrate-from-reason-react vs migrate-from-v3.
Would it be possible to choose a single file name for that doc, so routing does not change across versions, but keep the same titles that the users see now?

cristianoc added a commit that referenced this issue Jan 10, 2023
@cristianoc
Single migrate page.
5f743cf 
Fixes #641
@cristianoc cristianoc mentioned this issue Jan 10, 2023
Merged
@cristianoc
Copy link
Contributor

E.g. this: #643

cristianoc added a commit that referenced this issue Jan 10, 2023
@cristianoc
Single migrate page.
2547d77 
Fixes #641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Single migrate page. rescript-lang/rescript-lang.org
2 participants
@cristianoc @JiaeK