Skip to content
This repository was archived by the owner on Apr 24, 2021. It is now read-only.

No hover for items in a react component modules #67

Closed
amiralies opened this issue Feb 17, 2021 · 0 comments · Fixed by #68
Closed

No hover for items in a react component modules #67

amiralies opened this issue Feb 17, 2021 · 0 comments · Fixed by #68

Comments

@amiralies
Copy link
Contributor 

module X = {
  type t = int // no hover
  let x = 2 // no hover
 module Foo = { // no hover
    let a = 3
  }
  @react.component
  let make = () => React.null
}

hovers show up if i remove react component annotation
cristianoc added a commit that referenced this issue Feb 18, 2021
@cristianoc
Fix hover on definitions inside a react component module.
7242bbe 
This happens when a value is definied multiple times inside an inner module. E.g. @react.component defines `make` twice.

Fixes #67
@cristianoc cristianoc mentioned this issue Feb 18, 2021
Merged
cristianoc added a commit that referenced this issue Feb 18, 2021
@cristianoc
Fix hover on definitions inside a react component module.
3999139 
This happens when a value is definied multiple times inside an inner module. E.g. @react.component defines `make` twice.

Fixes #67
cristianoc added a commit to rescript-lang/rescript-vscode that referenced this issue Mar 15, 2021
@cristianoc
Sync up with rescript-editor-support c57ed6d
b4384e2 
Sync up with rescript-lang/rescript-editor-support@c57ed6d

#### New features
- Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from.
- Add support for autocomplete for decorators such as `@module` and `@val`.
- Add support for autocomplete of labelled arguments `foo(~label... )`.

#### Fixes

- Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62).
- Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63).
- Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72).
- Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67).
- Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72).
@cristianoc cristianoc mentioned this issue Mar 15, 2021
Merged
chenglou pushed a commit to rescript-lang/rescript-vscode that referenced this issue Mar 15, 2021
@cristianoc
Sync up with rescript-editor-support c57ed6d (#94)
951e285 
Sync up with rescript-lang/rescript-editor-support@c57ed6d

#### New features
- Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from.
- Add support for autocomplete for decorators such as `@module` and `@val`.
- Add support for autocomplete of labelled arguments `foo(~label... )`.

#### Fixes

- Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62).
- Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63).
- Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72).
- Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67).
- Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72).
cristianoc added a commit to rescript-lang/rescript-vscode that referenced this issue Mar 29, 2021
@cristianoc
Sync rescript-editor-support
4977546 
Sync rescript-editor-support to commit rescript-lang/rescript-editor-support@ae455c7

Since release 1.0.5:

#### New features
- Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from.
- Add support for autocomplete for decorators such as `@module` and `@val`.
- Add support for autocomplete of labelled arguments `foo(~label... )`.
- Add support for @deprecated attributes in autocomplete and hover.
- Support for upcoming `rescript` npm package for the compiler. Looks for `rescript` in addition to `bs-platform` in `node_modules`.

#### Fixes

- Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62).
- Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63).
- Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72).
- Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67).
- Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72).
- Autocomplete: add support for `open!` in addition to `open`.
@cristianoc cristianoc mentioned this issue Mar 29, 2021
Merged
chenglou pushed a commit to rescript-lang/rescript-vscode that referenced this issue Mar 30, 2021
@cristianoc
Sync rescript-editor-support (#99)
446f838 
* Sync rescript-editor-support

Sync rescript-editor-support to commit rescript-lang/rescript-editor-support@ae455c7

Since release 1.0.5:

#### New features
- Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from.
- Add support for autocomplete for decorators such as `@module` and `@val`.
- Add support for autocomplete of labelled arguments `foo(~label... )`.
- Add support for @deprecated attributes in autocomplete and hover.
- Support for upcoming `rescript` npm package for the compiler. Looks for `rescript` in addition to `bs-platform` in `node_modules`.

#### Fixes

- Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62).
- Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63).
- Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72).
- Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67).
- Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72).
- Autocomplete: add support for `open!` in addition to `open`.

* Don't show deprecated message on hover.

Sync up with rescript-lang/rescript-editor-support@03ee0d9
chenglou pushed a commit to chenglou/rescript-editor-support that referenced this issue Apr 24, 2021
@cristianoc @chenglou
Fix hover on definitions inside a react component module.
779725d 
This happens when a value is definied multiple times inside an inner module. E.g. @react.component defines `make` twice.

Fixes rescript-lang#67
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hover on definitions inside a react component module. rescript-lang/rescript-editor-support
1 participant
@amiralies