Documentation: Console #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
commented
Feb 13, 2023
| @@ -24,5 +24,5 @@ | |||
|
|
|||
| @val external trace: unit => unit = "console.trace" | |||
|
|
|||
| @val external timeStart: string => unit = "console.timeStart" | |||
| @val external time: string => unit = "console.time" | |||
There was a problem hiding this comment.
console.timeStart don't exist. See Console API
|
This is great work @aspeddro ! 👏 Reviewing soon. |
zth
reviewed
Feb 14, 2023
There was a problem hiding this comment.
This is looking great overall! However, since descriptions are copied from MDN, we need to figure out what to do about licenses. MDN descriptions are licensed as CC-BY-SA, so we need to give attribution. Question is whether we need to give attribution right next to every text, or if it's enough to give attribution somewhere central in the repo. Need to read up on that.
Another alternative is rewriting in our own words, taking inspiration from MDN and other sources, but not copying.
|
Ok, I'll rewrite. |
zth
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.