ReScript v11+: 1.0.0 #189
ReScript v11+: 1.0.0 #189
Conversation
|
cc @glennsl |
|
|
||
| function classify(value) { | ||
| var match = Object.prototype.toString.call(value); | ||
| switch (match) { | ||
| case "[object Array]" : | ||
| return { | ||
| TAG: /* Array */4, | ||
| TAG: "Array", |
There was a problem hiding this comment.
this js file was just very stale right?
There was a problem hiding this comment.
No, this was just the first time Core had v11+ as dep.
There was a problem hiding this comment.
Oh right v10 is older than I'd remember.
| var p$1 = Curry.__2(p); | ||
| var p$1 = function (a, b) { | ||
| return p(a, b); | ||
| }; |
There was a problem hiding this comment.
What's with the unnecessary wrapper functions here?
src/Core__Promise.res
Outdated
| external make: ((@uncurry (. 'a) => unit, (. 'e) => unit) => unit) => t<'a> = "Promise" | ||
| external make: ((@uncurry 'a => unit, 'e => unit) => unit) => t<'a> = "Promise" |
There was a problem hiding this comment.
@uncurry annotations can be removed?
There was a problem hiding this comment.
Actually, should probably preserve those uncurried dots instead, and let the annotation stay. Unless we decide to go full uncurried mode already.
There was a problem hiding this comment.
@glennsl I'll go ahead and just remove the @uncurry annotations, and we can let 1.0.0+ of Core be focused on uncurried mode (<1.0.0 can be used with curried mode in v11+ still). It'll be uncurried once it's in the compiler anyway, so seems like the best path forward.
This adapts Core to better fit ReScript v11+.
Going forward,
mainwill hold Core versions1.0.0+, and be fully adapted to v11.https://github.com/rescript-association/rescript-core/tree/0.x will hold
0.xversions, and they will be compatible with<11as well.