feat(@react-router/dev): remove deprecated ABORT_DELAY in favor of streamTimeout
#12478
Conversation
🦋 Changeset detectedLatest commit: 1cf17f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -11,7 +11,6 @@ import { StreamTransfer } from "./single-fetch"; | |||
| export interface ServerRouterProps { | |||
| context: EntryContext; | |||
| url: string | URL; | |||
| abortDelay?: number; | |||
There was a problem hiding this comment.
Removing this prop would be a breaking change
There was a problem hiding this comment.
I'd add a warning for now that it's non-functional and deprecated.
There was a problem hiding this comment.
Making it non-functional would be a breaking change as well
Deprecating it and pointing towards using streamTimeout would be a good idea though!
There was a problem hiding this comment.
I think it's already non-functional, though. At least based on the issue that spawned this PR.
There was a problem hiding this comment.
yeah it's now a useless prop that was supposed to be removed in 7.0.0 but got missed. I think you can view it as a types bug fix since the type allows you to pass a thing that does nothing. FWIW it's also a build-time "break" not a runtime functional breaking change.
There was a problem hiding this comment.
Confirmed with the tam we feel this is a types bug fix.
Another advantage is the error TS will provide after this change is a good thing because if you are still passing abortDelay in RR v7 then it's highly likely you have a functional bug in your app because your streams are not going to timeout properly. Surfacing this TS proper error will alert you to fix that bug.
MichaelDeBoey
changed the title
ABORT_DELAY in favor of streamTimeout
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Closes #12467