enforce same thread on getState() #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patjackson52
force-pushed
the
feature/thread-enforce
branch
from
0682134 to
442414f
Compare
patjackson52
changed the title
patjackson52
force-pushed
the
feature/thread-enforce
branch
from
14671cd to
5bd8adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #12
I was unable to implement win, linux, and wasm. Being I don't know of anyone using kotlinredux on those platforms I don't consider it a blocker. Library will work, but does not have same thread enforcement.
Before this PR, if accessed from another thread it may through the exception from the isDispatching check if dispatching was happing on another thread. This new exception will be more informative.