Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci upgrade #118

Merged
merged 1 commit into from
Jan 16, 2023
Merged

ci upgrade #118

merged 1 commit into from
Jan 16, 2023

Conversation

mpetuska
Copy link
Contributor

  • Multiplatform tests
  • Automatic snapshot version releases and bumps
  • Full releases are now triggered by creating a GH release with tag x.y.z
  • Dokka publication to gh pages on full release

@mpetuska mpetuska marked this pull request as ready for review January 16, 2023 19:56
@mpetuska
Copy link
Contributor Author

Before merging this will need branch protection rule update to expect the new builds.

@mpetuska mpetuska force-pushed the ci-update branch 2 times, most recently from 484247c to 2fca192 Compare January 16, 2023 20:06
Copy link
Contributor

@patjackson52 patjackson52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr of automatic version bumps? snapshots are published to github packages & releases are github packages & maven central?
Would be nice to capture in docs. Nice addition of gh pages.

@mpetuska
Copy link
Contributor Author

tl;dr of automatic version bumps?

In short it basically works as follows:

  • When stuff is committed/merged to master or a new tag is created (via gh release) release build runs
  • Within release build there's a call to resolve-version build
  • resolve-version build reads the ref, tag and gradle.properties and figures out the desired version
  • If the desired version is SNAPSHOT (i.e. gradle.properties version won) it publishes snapshot builds to gh packages and maven central
  • If the version is NOT snapshot (i.e. tag ref won)
    • It publishes release builds to GH packages and maven central.
    • It bumps patch version of the resolved version and makes it SNAPSHOT (i.e. x.y.<z+1>-SNAPSHOT)
    • Then it writes that new SNAPSHOT version to gradle.properties and pushes it back to the master branch

There are some more minor caveats to this, but that's how it works in a nutshell.

@mpetuska mpetuska enabled auto-merge (rebase) January 16, 2023 20:49
Copy link
Contributor

@patjackson52 patjackson52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mpetuska
Copy link
Contributor Author

mpetuska commented Jan 16, 2023

Before merging this will need branch protection rule update to expect the new builds.

@patjackson52 can you sort this out, please? Old test and ktlint builds will never start on this PR because they're no longer there 😁

@patjackson52 patjackson52 disabled auto-merge January 16, 2023 21:05
@patjackson52
Copy link
Contributor

Before merging this will need branch protection rule update to expect the new builds.

@patjackson52 can you sort this out, please? Old test and ktlint builds will never start on this PR because they're no longer there 😁

updated rules - manually merged this one as the checks weren't updating - everything passed

@patjackson52 patjackson52 enabled auto-merge (rebase) January 16, 2023 21:08
@patjackson52 patjackson52 disabled auto-merge January 16, 2023 21:13
@patjackson52 patjackson52 merged commit 26e217a into master Jan 16, 2023
@mpetuska mpetuska deleted the ci-update branch January 16, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants