Added windows virtual environment activation command. Closes #942 #946
Conversation
|
@suryasr007 |
|
Hi @mpoulin, As I mentioned in guide, 'venv' is the general convention used globally. As it is readily available in ignore files (eg: .gitignore'). |
docs/dev/virtualenvs.rst
Outdated
| placed in the ``my_project`` folder, isolated from the global Python installation. | ||
| placed in the ``venv`` folder, isolated from the global Python installation. | ||
|
|
||
| For windows, same command which is mentioned in step 1 can be used for creation of virtual environment. But, to activate, we use the following command. |
There was a problem hiding this comment.
"Windows" should be capitalized.
There was a problem hiding this comment.
Thanks for pointing out. I will change it.
docs/dev/virtualenvs.rst
Outdated
|
|
||
| For windows, same command which is mentioned in step 1 can be used for creation of virtual environment. But, to activate, we use the following command. | ||
|
|
||
| Assuming that, you are in project directory: |
There was a problem hiding this comment.
Typo: no comma necessary here.
There was a problem hiding this comment.
Thanks for pointing out. I will change it.
docs/dev/virtualenvs.rst
Outdated
| @@ -284,6 +295,9 @@ After a while, though, you might end up with a lot of virtual environments | |||
| littered across your system, and its possible you'll forget their names or | |||
| where they were placed. | |||
|
|
|||
| .. note:: | |||
| Python has included virtual environment module from 3.3. It works in the simliar way as mentioned above. For details: `venv <https://docs.python.org/3/library/venv.html>`_. | |||
There was a problem hiding this comment.
Typo: "similar".
Should probably also be "...included the virtual...".
There was a problem hiding this comment.
Can you please elaborate this?
There was a problem hiding this comment.
This is just an English grammar issue, I think. For a non-proper noun "foo", if you say "X has included foo", it really needs an article like "X has include a foo" or "X has included the foo". Plain "X has included foo" only works for proper nouns/names of the form "X has included Foo" For that form, it would be "Python has included venv from 3.3.". That would be okay since "venv" is a proper noun since it's the actual name of the module.
There was a problem hiding this comment.
Thanks @apjanke for the clarification.
|
HI @apjanke |
|
Looks good to me now. |
Yeah, sorry my bad. I will rectify that. |
Issue: 942
Additional Changes