Skip to content

Removed references to Setuptools/easy_install in favor of pip. #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 7, 2016

Conversation

adamn
Copy link
Contributor

@adamn adamn commented Mar 14, 2016

A new Python user hardly needs to know that easy_install ever existed.

Also addresses #676 for OS X. Open to suggestions.

@kennethreitz
Copy link
Contributor

Setuptools is still required for Pip to operate.

I don't like how the virtualenv section was converted to Python3.

maintaining a project which requires Django 1.8.

If you are using Python 3, make sure you run something like the following (or
have it in your env variables in `~/.bashrc`):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be valid reStructuredText, this should have two backticks on either side, e.g.,

in ``~/.bashrc``):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@adamn
Copy link
Contributor Author

adamn commented Mar 15, 2016

Setuptools is required for Pip but since users aren't directly using Setuptools in the installation section it seems ancillary. Any Setuptools discussion might better belong in the Packaging section since beginning users only need to know about pip IMHO.

Anyway, I'm happy to undo that.

As for the virtualenv changes, if a Python 3 user reads that section without the Python 3 information, they will get very lost. Virtualenv will appear to work but the environments will all be Python2. We need to help out users who have installed Python3 and want virtualenv to function the way the docs say it will.

I've updated that change to be less vocal - let me know what you think. I still think the -p flag example should simply point to a python3 version since that is the common use case. These days more beginning people are likely to us Python 2 and 3 side by side rather than two different Python 2s. Non-beginners will understand that -p allows for any python interpreter.

@kennethreitz
Copy link
Contributor

@adamn I think a better approach for the virtualenv section is to return it to it's previous (Python 2) state, and perhaps add a section explaining the use of the $ virtualenv -p python3 option. Most people don't know about this, and explaining it to them right away may make things much easier for them down the road (as well as help them understand what virtualenv is actually doing).

@kennethreitz
Copy link
Contributor

seutptools still needs to be restored to installation.rst :)

You do not need to install or configure anything else to use Python. Having
said that, I would strongly recommend that you install the tools and libraries
described in the next section before you start building Python applications
for real-world use. In particular, you should always install Setuptools, as it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think removing setuptools here is a good idea. It's important to know about these tools, even if you aren't going to use them directly.

@kennethreitz
Copy link
Contributor

According to @dstufft, pip plans to automatically install setuptools in the future. Let's hold off on this until then.

@adamn
Copy link
Contributor Author

adamn commented Mar 31, 2016

I re-instated the setuptools references. Maybe we can just try to get the Python3 Mac docs up and close this? A new ticket can be opened if/when pip automatically installs setuptools in the future.

@kennethreitz
Copy link
Contributor

+1

@kennethreitz
Copy link
Contributor

This appears to require a rebase.


One of these days, I intend to sit down and refactor these with Python 3 guides available as well. I have a feeling I'll start spending more time on this project very soon.

Hopefully I'm right :)

@adamn
Copy link
Contributor Author

adamn commented Aug 26, 2016

Should I rebase this or just delete it?

@kennethreitz
Copy link
Contributor

i think i will merge it, with a few changes

@adamn
Copy link
Contributor Author

adamn commented Nov 2, 2016

I'm also happy to rebase/update, just let me know. Otherwise, maybe we should just get this in and do other updates in another PR

@kennethreitz
Copy link
Contributor

whatever lets me do the "merge" button easily :)

@kennethreitz
Copy link
Contributor

"This branch has conflicts that must be resolved"

@kennethreitz
Copy link
Contributor

I could always resolve myself, but.. you know :)

@kennethreitz
Copy link
Contributor

are you ever going to make these changes?

@kennethreitz kennethreitz merged commit c939324 into realpython:master Dec 7, 2016
@adamn
Copy link
Contributor Author

adamn commented Dec 7, 2016

If there's more you need, just let me know.

@kennethreitz
Copy link
Contributor

i made the changes myself :)

@kennethreitz
Copy link
Contributor

thank you very much! We need to update the other two installation guides now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants