Skip to content

PeclEvLoop: Add new PeclEvLoop (PECL ext-ev) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivkalita wants to merge 17 commits into from
Closed

PeclEvLoop: Add new PeclEvLoop (PECL ext-ev) #97

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4455a3b
Add loop driver for pecl libev extension.
markkimsal Mar 21, 2015
051a4a3
Document new driver.
markkimsal Mar 21, 2015
0b375f7
Replace "EvLoop::defaultLoop()" with "new EvLoop()".
ivkalita Apr 8, 2017
3391da5
Fix PeclEvLoop SplObjectStorage item retrieving method.
ivkalita Apr 8, 2017
0e56b44
Remove unnecessary "use" statements from PeclEvLoop.
ivkalita Apr 8, 2017
316e6a9
Remove nextTickQueue from PeclEvLoop.
ivkalita Apr 8, 2017
4c70da0
Rename PeclEvLoop private members in StreamSelectLoop way.
ivkalita Apr 8, 2017
3ae1829
Prevent PeclEvLoop from updating existing streams callbacks.
ivkalita Apr 8, 2017
52e5e2e
Add early returns in PeclEvLoop removeReadStream, removeWriteStream a…
ivkalita Apr 8, 2017
5392032
Make PeclEvLoop::run more verbose.
ivkalita Apr 8, 2017
45b7ab0
Add PeclEvLoop::__destruct() to prevent SEGFAULT.
ivkalita Apr 8, 2017
42bc95d
Remove unnecessary PeclEvLoop::tick().
ivkalita Apr 18, 2017
dac7c41
Remove unnecessary "@inheritdoc" from PeclEvLoop.
ivkalita Apr 21, 2017
41d9d63
Add base test for canceling non-existent timer.
ivkalita Apr 21, 2017
2ef8ff0
Add PeclEvLoop test.
ivkalita Apr 21, 2017
54710a3
Add PeclEvLoopTimerTest.
ivkalita Apr 21, 2017
79dd25c
Add PECL ev extension to travis-init.sh.
ivkalita Apr 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add PeclEvLoop test.
  • Loading branch information
@ivkalita
ivkalita committed Apr 21, 2017
commit 2ef8ff0ebe8352470e78350f37e12e3a694102e6
17 changes: 17 additions & 0 deletions tests/PeclEvLoopTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

Copy link
Member

@jsor jsor Apr 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't add @author doc blocks.

Copy link
Contributor Author

@ivkalita ivkalita Apr 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsor, thanks, I'll keep that in mind next time 😄. I removed them in 54de798.

namespace React\Tests\EventLoop;

use React\EventLoop\PeclEvLoop;

class PeclEvLoopTest extends AbstractLoopTest
{
public function createLoop()
{
if (!class_exists('EvLoop')) {
$this->markTestSkipped('pecl-ev tests skipped because ext-ev is not installed.');
}

return new PeclEvLoop();
}
}