Skip to content

Fix text in docs #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2023
Merged

Fix text in docs #6253

merged 5 commits into from
Sep 23, 2023

Conversation

@smdmori
Copy link
Contributor

@smdmori smdmori commented Aug 23, 2023

The question and it's solutions had a minor mismatch in text

image
image

useState is deleted, so we can delete it's import too

image
react dev

@facebook-github-bot
Copy link
Collaborator

facebook-github-bot commented Aug 23, 2023

Hi @smdmori!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@smdmori smdmori changed the title Fix text in 2 challenges Fix text in docs Sep 3, 2023
smdmori
smdmori commented Sep 3, 2023
View reviewed changes
src/content/learn/removing-effect-dependencies.md
Copy link
Contributor Author

@smdmori smdmori Sep 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first edit, It should pass options object like the codes below and after it

in the second one, there is just a misplacing of the verb

smdmori
smdmori commented Sep 3, 2023
View reviewed changes
src/content/learn/synchronizing-with-effects.md
Copy link
Contributor Author

@smdmori smdmori Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clearer in this way, maybe I'm wrong?

sophiebits
sophiebits reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes!

@sophiebits sophiebits merged commit 1758515 into reactjs:main Sep 23, 2023
ltlaitoff added a commit to ltlaitoff/uk.react.dev that referenced this pull request Nov 7, 2023
@ltlaitoff
sync: Sync "passing-props-to-a-component" uk version with en
278bdec 
Pull request: reactjs/react.dev#6253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophiebits sophiebits sophiebits left review comments

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smdmori @facebook-github-bot @sophiebits