This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Make react-charts compatible with react@0.14.0-rc1 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
But react 0.14 isn't released yet and it might break compatibility so I'm not sure if this should be merged yet |
Contributor
Author
|
package.json refers a "test" command but I don't see any tests |
oliger
added a commit
to hull/react-chartjs
that referenced
this pull request
Oct 9, 2015
Make react-charts compatible with react@0.14.0-rc1
Merged
|
I think this should be merged now because react 0.14 was released already. |
|
👍 |
|
+1 needing this one to move forward to 0.14. |
|
Yep, +1 from me as well. Would also be a good idea to update the compiled versions in /dist. |
|
+1 |
1 similar comment
|
+1 |
Contributor
Author
|
Do I read correctly that this pull request is outdated and peerDependencies are the way to got and #54 already added all the things that I didn't? |
Contributor
Author
|
Well, then we can just close this :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.