Conversation
|
Hey @ricardoerl, thanks for contributing! Let us know if you need any help with this! |
|
Deploy preview for es-reactjs ready! Built with commit a93f0ab |
|
Hey @ricardoerl I’ll take a look tonight, thanks! |
Darking360
left a comment
There was a problem hiding this comment.
Greetings @ricardoerl thanks you for a great PR! 🚀
I just left you some comments, a little parts that were not translated and one or two recommendations for a clearer reading 💪 Let me know for any questions, and when you update those we'll be good to go 🥇
Thanks a lot! 👍
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
|
@Darking360 changes approved. Thanks a lot for the help 🙌 |
|
The build is failing because you have long line comments in .js files. You should run Prettier. |
|
@ricardoerl Greetings! There are some changes left, maybe you didn't expand the selection of feedback, it has a |
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Co-Authored-By: ricardoerl <ricardo.ramirezlara@gmail.com>
Darking360
left a comment
There was a problem hiding this comment.
Hey @ricardoerl looks great for me! Thanks for the amazing work! 🚀
Spanish translation of Context documentation.
Todo: