Translation of "Hooks at a Glance" page#70
Merged
carburo merged 6 commits intoreactjs:masterfrom Feb 8, 2019
Merged
Conversation
alejandronanez
requested changes
Feb 4, 2019
Member
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
Hey @GiuMagnani, thanks for your hard work here, this is getting super close to what we need! 🙌
I left a couple of suggestions that should be addressed before merging this!
Thanks a lot!
Fix missed "Hooks" Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
Fixed wrong translation for "Effect Hook". Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
Contributor
Author
|
Thanks @alejandronanez for the corrections! I already committed them. Let me know if there is anything else. |
alejandronanez
approved these changes
Feb 8, 2019
Member
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
Awesome work as always @GiuMagnani!
Thank you very much!
alejandronanez
requested changes
Feb 8, 2019
Member
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
@GiuMagnani, oops, it seems that you have some merge conflicts on your branch.
Please, fix them and this will be ready to merge!
Contributor
Author
|
@alejandronanez I'll take a look, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 (comment)