-
Notifications
You must be signed in to change notification settings - Fork 535
Allow triggerRequest and signalCancel to be coalesced #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow triggerRequest and signalCancel to be coalesced #462
Conversation
stage.expectRequest(); | ||
stage.puppet().signalCancel(); | ||
stage.expectCancelling(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we expect the request before signalling cancel, preventing the coalescing of the request and cancel, and by expecting cancelling before signalling next, we ensure that signalling next does test what this test says it tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable and less prone to race conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. the behavior you described sounds like an improvement.
@reactive-streams/contributors Feedback on this? |
I'm not sure. Is this something because of Akka Stream's sequential signal count and mixing requests with cancellation in the same actor message queue? |
@viktorklang - can we merge this, cut an RC, and collect comments when folks kick the tires on the RC? |
@Scottmitch Agreed—people have had ample time to respond as is. Will tackle this on Monday |
See #453 and #441 (comment)