Skip to content

Set React's onChange property for input elements if its not provided #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set React's onChange property for input elements if its not provided #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/js/packages/@reactpy/client/src/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ function UserInputElement({ model }: { model: ReactPyVdom }): JSX.Element {
// allow the client to respond (and possibly change the value)
givenOnChange(event);
};
} else if (!givenOnChange) {
props.onChange = (event: ChangeEvent<any>) => {
// set the value so rerender doesn't stomp on state
setValue(event.target.value);
}
}

// Use createElement here to avoid warning about variable numbers of children not
Expand Down
Loading