Add controlled popover #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmelmicro
requested review from
adamkudrna,
bedrich-schindler and
mbohal
as code owners
mbohal
reviewed
Dec 4, 2024
bedrich-schindler
requested changes
Dec 6, 2024
mbohal
approved these changes
Dec 10, 2024
bedrich-schindler
approved these changes
Dec 10, 2024
|
I am approving this PR even though SCSS comments are not done as required. But it is up to @adamkudrna to approve them. |
adamkudrna
approved these changes
Jan 10, 2025
atmelmicro
force-pushed
the
feature/controlled-popover
branch
from
7d83de3 to
275469d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Popover API with the help of a helper element this implements a native way to create a popover that closes and opens on button and backdrop click.