Update dependencies (#227) #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adamkudrna
added
dependencies
adamkudrna
approved these changes
Feb 9, 2021
package.json
Outdated
| "eslint-loader": "^4.0.2", | ||
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-jsx-a11y": "^6.4.1", | ||
| "eslint-plugin-markdown": "^2.0.0-rc.0", |
There was a problem hiding this comment.
How about bumping this to RC2?
There was a problem hiding this comment.
RC2 is currently installed due to ^. Can update it.
package.json
Outdated
| "nodemon": "^2.0.6", | ||
| "postcss": "^8.2.1", | ||
| "postcss-loader": "^4.1.0", | ||
| "markdownlint-cli2": "^0.0.13", |
There was a problem hiding this comment.
Let's be careful with 0.x versions, I'd leave out the ^.
There was a problem hiding this comment.
Yep, I overlooked this. Thx
bedrich-schindler
force-pushed
the
feature/227
branch
from
dc9e924 to
f1fb32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamkudrna For info, there are few incompatibilities that do not allow us to update everything to the latest versions.
React 17 cannot be updated due to missing Rect 17 adapter for enzyme (will be released soon), Webpack cannot be updated because Gatsby do not suport Webpack 5. Sass loader and postcss loader are broken, I was not able to fix it.
@babel/plugin-transform-spreadmust have been added to solve Gatsby issues, we need to remove it later when it will be resolved.