Extend theming options of Buttons and form fields (#210)
#212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
commented
Jan 14, 2021
mbohal
approved these changes
Jan 18, 2021
mbohal
reviewed
Jan 19, 2021
bedrich-schindler
approved these changes
Jan 20, 2021
|
|
||
| ### Basic Theming | ||
|
|
||
| The following theme options define basic appearance of form fields. The options |
There was a problem hiding this comment.
Not sure if The options is correct. I think that the should be omit
There was a problem hiding this comment.
My feeling is it's rather correct, it relates to the options mentioned in the previous sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttonand "new" form fields (TextField,TextArea,SelectField) theming options to be dynamically generated based on SCSS settings.--rui-form-field-border-color--rui-form-field-hover-border-color--rui-form-field-focus-border-color--rui-form-field-filled-disabled-color,--rui-form-field-outline-disabled-box-shadow,--rui-form-field-valid-default-backgroundoptions added etc.--rui-form-field-<SIZE>-padding-verticaland--rui-form-field-<SIZE>-padding-horizontalto--rui-form-field-<SIZE>-padding-yand--rui-form-field-<SIZE>-padding-x.Buttontheming options:--rui-button-disabled-opacity--rui-button-disabled-cursor--rui-button-group-filled-separator-colorCloses #210.