Skip to content

Adjust the size of number-type TextField according to the max attribute #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Adjust the size of number-type TextField according to the max attribute #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8313bad
Adjust the size of number-type `TextField` according to the `max` att…
adamkudrna Sep 16, 2020
400701d
Remove extra inset shadow from inputs on mobile Safari
adamkudrna Sep 16, 2020
8ba41de
Fix color of `Toggle` in validation states
adamkudrna Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/demo/pages/DemoContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,16 +2986,31 @@ class DemoContainer extends React.Component {
<TextField
id="textFieldCustomInputSizeOutline"
changeHandler={logger}
label="Age"
label="Title"
inputSize={3}
/>
<TextField
id="textFieldCustomInputSizeFilled"
changeHandler={logger}
label="Age"
label="Title"
variant="filled"
inputSize={3}
/>
<TextField
id="textFieldCustomInputSizeNumberOutline"
changeHandler={logger}
label="Age"
max={100}
type="number"
/>
<TextField
id="textFieldCustomInputSizeNumberFilled"
changeHandler={logger}
label="Age"
variant="filled"
max={100}
type="number"
/>
</div>
)}
/>
Expand Down
6 changes: 6 additions & 0 deletions src/lib/components/screens/Login/__tests__/__snapshots__/ForgotPassword.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ exports[`rendering renders correctly 1`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -91,6 +92,7 @@ exports[`rendering renders correctly 1`] = `
className="input"
disabled={false}
id="resetEmailInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -209,6 +211,7 @@ exports[`rendering renders correctly 2`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -247,6 +250,7 @@ exports[`rendering renders correctly 2`] = `
className="input"
disabled={false}
id="resetEmailInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -393,6 +397,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -431,6 +436,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
className="input"
disabled={false}
id="custom-id__resetEmailInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down
16 changes: 16 additions & 0 deletions src/lib/components/screens/Login/__tests__/__snapshots__/Login.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ exports[`rendering renders correctly 1`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -93,6 +94,7 @@ exports[`rendering renders correctly 1`] = `
className="input"
disabled={false}
id="usernameInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -126,6 +128,7 @@ exports[`rendering renders correctly 1`] = `
isLabelVisible={true}
label="Password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -164,6 +167,7 @@ exports[`rendering renders correctly 1`] = `
className="input"
disabled={false}
id="passwordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -311,6 +315,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -349,6 +354,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
className="input"
disabled={false}
id="custom-id__usernameInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -382,6 +388,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
isLabelVisible={true}
label="Password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -420,6 +427,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
className="input"
disabled={false}
id="custom-id__passwordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -556,6 +564,7 @@ exports[`rendering renders correctly with translations 1`] = `
isLabelVisible={true}
label="E-mail"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -594,6 +603,7 @@ exports[`rendering renders correctly with translations 1`] = `
className="input"
disabled={false}
id="usernameInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -627,6 +637,7 @@ exports[`rendering renders correctly with translations 1`] = `
isLabelVisible={true}
label="Heslo"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -665,6 +676,7 @@ exports[`rendering renders correctly with translations 1`] = `
className="input"
disabled={false}
id="passwordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -781,6 +793,7 @@ exports[`rendering renders correctly with username 1`] = `
isLabelVisible={true}
label="Username"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -819,6 +832,7 @@ exports[`rendering renders correctly with username 1`] = `
className="input"
disabled={false}
id="usernameInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -852,6 +866,7 @@ exports[`rendering renders correctly with username 1`] = `
isLabelVisible={true}
label="Password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -890,6 +905,7 @@ exports[`rendering renders correctly with username 1`] = `
className="input"
disabled={false}
id="passwordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down
12 changes: 12 additions & 0 deletions src/lib/components/screens/Login/__tests__/__snapshots__/NewPassword.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ exports[`rendering renders correctly 1`] = `
isLabelVisible={true}
label="New password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -91,6 +92,7 @@ exports[`rendering renders correctly 1`] = `
className="input"
disabled={false}
id="newPasswordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -124,6 +126,7 @@ exports[`rendering renders correctly 1`] = `
isLabelVisible={true}
label="Repeat new password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -162,6 +165,7 @@ exports[`rendering renders correctly 1`] = `
className="input"
disabled={false}
id="newPasswordRepeatInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -307,6 +311,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
isLabelVisible={true}
label="New password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -345,6 +350,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
className="input"
disabled={false}
id="custom-id__newPasswordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -378,6 +384,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
isLabelVisible={true}
label="Repeat new password"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -416,6 +423,7 @@ exports[`rendering renders correctly with all props except translations 1`] = `
className="input"
disabled={false}
id="custom-id__newPasswordRepeatInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -549,6 +557,7 @@ exports[`rendering renders correctly with translations 1`] = `
isLabelVisible={true}
label="Nové heslo"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -587,6 +596,7 @@ exports[`rendering renders correctly with translations 1`] = `
className="input"
disabled={false}
id="newPasswordInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down Expand Up @@ -620,6 +630,7 @@ exports[`rendering renders correctly with translations 1`] = `
isLabelVisible={true}
label="Nové heslo znovu"
layout="vertical"
max={null}
placeholder={null}
required={true}
size="medium"
Expand Down Expand Up @@ -658,6 +669,7 @@ exports[`rendering renders correctly with translations 1`] = `
className="input"
disabled={false}
id="newPasswordRepeatInput"
max={null}
onChange={[Function]}
placeholder={null}
required={true}
Expand Down
Loading