updated themes.md to include appearances URL #927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-docs ready! Built with commit c3422ef https://deploy-preview-927--react-navigation-docs.netlify.app |
eriveltonelias
requested changes
Jan 28, 2021
Member
eriveltonelias
left a comment
eriveltonelias
left a comment
There was a problem hiding this comment.
thanks for your PR! I just left one small comment.
| ## Using the operating system preferences | ||
|
|
||
| At the time of writing, `react-native` does not currently support detecting the operating system color scheme preferences in the core ([you can follow this pull request](https://github.com/facebook/react-native/pull/26172)). Until it is part of core and you have updated to the version that includes it, you can use `react-native-appearance`. | ||
| appearance is a part of react native and can see more details here https://reactnative.dev/docs/appearance. |
Member
There was a problem hiding this comment.
I think we should explain a little bit more about using the system preferences ( Appearance module ) before we reference this to a link
Member
|
closing in favor of #942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ ME PLEASE!
TL;DR: Make sure to add your changes to versioned docs
Thanks for opening a PR!
The docs cover several versions of
react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").Please make sure that the edit you're making in
docs/file-you-edited.mdis also included in the file for the correct version, eg./versioned_docs/version-3.x/file-you-edited.mdfor version 3. If such file doesn't exist, please create it. 👍