Add description about 'collapsible header' on sidebar. #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation ready! Built with commit 7697743 |
vonovak
requested changes
Aug 20, 2018
Member
vonovak
left a comment
vonovak
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you address the comments? Thanks.
docs/collapsible-header.md
Outdated
| sidebar_label: Collapsible header | ||
| --- | ||
|
|
||
| react-navigation-collapsible is a library and a `High Order Component` that adjusts your navigationOptions and makes your screen collapsible. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
docs/collapsible-header.md
Outdated
| Install the react-navigation-collapsible package in your project: | ||
|
|
||
| ``` | ||
| npm install react-navigation-collapsible |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
docs/collapsible-header.md
Outdated
| contentContainerStyle={{ paddingTop: paddingHeight }} | ||
| scrollIndicatorInsets={{ top: paddingHeight }} | ||
| _mustAddThis={ scrollY } | ||
| onScroll={ onScroll } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
Author
|
Thanks for your review! |
Contributor
Author
|
I fixed it and pushed it again :) |
benevbright
commented
Aug 24, 2018
Contributor
Author
benevbright
left a comment
benevbright
left a comment
There was a problem hiding this comment.
Done. Thanks.
Member
|
thanks @benevbright! We'll probably make small changes to the community navigators section, so don't be surprised if the published docs look a little different. |
Contributor
Author
|
Absolutely! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.