Skip to content

Conversation

@patrycjakalinska
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit f6e4e58
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/65d753044e59cf0008c7ab20
😎 Deploy Preview https://deploy-preview-1310--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this PR is true. In Static API Typescript is mostly inferred when properly set-up. This was explained in https://reactnavigation.org/docs/7.x/static-typescript

So I don't think we need this in this form?

@patrycjakalinska patrycjakalinska changed the title Migrate 'Type checking with TypeScript' examples to v7 Migrate 'Type checking with TypeScript' examples to static API in v7 Feb 23, 2024
@satya164
Copy link
Member

Yeah, I think we should move the whole page content of https://reactnavigation.org/docs/7.x/static-typescript and basically the tabs will contain the full content of the page.

We should do similar for https://reactnavigation.org/docs/7.x/static-authentication as well.

Then https://reactnavigation.org/docs/7.x/static-combine-with-dynamic can be moved to under "Guides".

The remaining one https://reactnavigation.org/docs/7.x/static-api-reference can be then moved to under the "API references" section and renamed to "Static API reference"

These pages were written before we decided with the tab approach so that's why they are on different pages right now.

@satya164 satya164 force-pushed the main branch 2 times, most recently from a2a5d9e to fcb5e31 Compare February 28, 2024 16:34
@kacperkapusciak
Copy link
Member

Superseded by 6765a7c

@satya164 satya164 deleted the @patrycjakalinska/typescript-to-v7 branch March 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants