Example consistency fix #1264
Open
Example consistency fix #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated an example to match how the rest of the documentation uses that and similar functions. I (an infrequent JS user) was confused by the original code.
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
force-pushed
the
main
branch
2 times, most recently
from
a2a5d9e to
fcb5e31
Compare
satya164
force-pushed
the
main
branch
5 times, most recently
from
65c6448 to
df873a5
Compare
satya164
force-pushed
the
main
branch
2 times, most recently
from
a739841 to
35a6db3
Compare
satya164
force-pushed
the
main
branch
2 times, most recently
from
7dbaa57 to
9e2af9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank's for taking the time to review. This change matches the example code in other sections like v5 linkto, and the example of getPathFromState right underneath the modified code. As an infrequent JS coder the inconsistency caused me some confusion. Hopefully this change will help others in my position.